suddjian commented on a change in pull request #15568:
URL: https://github.com/apache/superset/pull/15568#discussion_r666478260
##########
File path:
superset-frontend/src/explore/components/controls/DatasourceControl/index.jsx
##########
@@ -190,7 +195,7 @@ class DatasourceControl extends React.PureComponent {
return (
<Styles data-test="datasource-control" className="DatasourceControl">
<div className="data-container">
- <Icon name="dataset-physical" className="dataset-svg" />
+ <Icons.DatasetPhysical className="dataset-svg" />
Review comment:
I disagree, I think having a consistent icon here adds clarity. To me
the icon is doing the job of communicating "this is the dataset control" rather
than "this is the type of this dataset". But that decision should probably be
left to design folks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
