michael-s-molina commented on a change in pull request #15568:
URL: https://github.com/apache/superset/pull/15568#discussion_r666490504
##########
File path:
superset-frontend/src/explore/components/controls/DatasourceControl/index.jsx
##########
@@ -190,7 +195,7 @@ class DatasourceControl extends React.PureComponent {
return (
<Styles data-test="datasource-control" className="DatasourceControl">
<div className="data-container">
- <Icon name="dataset-physical" className="dataset-svg" />
+ <Icons.DatasetPhysical className="dataset-svg" />
Review comment:
One question that we can ask is: In the context of Explore, is important
for the user to know if he's working on a physical or virtual dataset? Is there
any difference in terms of functionality? @rusackas @betodealmeida
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
