michael-s-molina commented on a change in pull request #15568:
URL: https://github.com/apache/superset/pull/15568#discussion_r666484002
##########
File path:
superset-frontend/src/explore/components/controls/DatasourceControl/index.jsx
##########
@@ -190,7 +195,7 @@ class DatasourceControl extends React.PureComponent {
return (
<Styles data-test="datasource-control" className="DatasourceControl">
<div className="data-container">
- <Icon name="dataset-physical" className="dataset-svg" />
+ <Icons.DatasetPhysical className="dataset-svg" />
Review comment:
I'm fine either way, but I liked @zhaoyongjie suggestion. The icons are
similar enough to let the user know that they represent a dataset. With
different icons, we have additional information (virtual or physical).
<img width="38" alt="Screen Shot 2021-07-08 at 5 04 54 PM"
src="https://user-images.githubusercontent.com/70410625/124983675-a3f77680-e00e-11eb-9a74-a9ea67f85523.png";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/70410625/124983675-a3f77680-e00e-11eb-9a74-a9ea67f85523.png"](https://user-images.githubusercontent.com/70410625/124983675-a3f77680-e00e-11eb-9a74-a9ea67f85523.png"){kind=link}