betodealmeida commented on a change in pull request #15568:
URL: https://github.com/apache/superset/pull/15568#discussion_r666671529
##########
File path:
superset-frontend/src/explore/components/controls/DatasourceControl/index.jsx
##########
@@ -190,7 +195,7 @@ class DatasourceControl extends React.PureComponent {
return (
<Styles data-test="datasource-control" className="DatasourceControl">
<div className="data-container">
- <Icon name="dataset-physical" className="dataset-svg" />
+ <Icons.DatasetPhysical className="dataset-svg" />
Review comment:
@michael-s-molina it shouldn't matter, everything the user does on a
physical dataset in Explore they should be able to in a virtual, and vice-versa.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
