michael-s-molina commented on a change in pull request #16414:
URL: https://github.com/apache/superset/pull/16414#discussion_r695268134
##########
File path: superset-frontend/src/addSlice/AddSliceContainer.tsx
##########
@@ -194,6 +196,8 @@ export default class AddSliceContainer extends
React.PureComponent<
this.newLabel = this.newLabel.bind(this);
this.loadDatasources = this.loadDatasources.bind(this);
this.handleFilterOption = this.handleFilterOption.bind(this);
Review comment:
@ktmud @etr2460 `filterSort` is useful when all the values are present
in the select. It's less useful when we are using the async version of our
select, which is the majority of the cases. In the async version, the sorting
should be done on the server-side before the pagination to ensure the correct
results are returned. Client-side sorting on paginated requests can produce
wrong results. We can use `match-sorter` for the sync version but so far we
haven't found any case where the default sorting wasn't sufficient. I think the
best way to fix this is to make the endpoint respect the sorting parameters and
implement the exact match behavior on the server-side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
