eschutho commented on a change in pull request #18629:
URL: https://github.com/apache/superset/pull/18629#discussion_r804259269
##########
File path: superset-frontend/src/views/components/Menu.tsx
##########
@@ -284,6 +298,7 @@ export function Menu({
className="main-nav"
>
{menu.map(item => {
+ if (item.name === 'Upload Data') return null;
Review comment:
wdyt is better? Having a null item in the array or filtering the value
out before mapping? I'm not sure what an empty element does in the array here
for the menu, but it seems that maybe just removing it would be cleaner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
