pkdotson commented on a change in pull request #18629:
URL: https://github.com/apache/superset/pull/18629#discussion_r804282693
##########
File path: superset-frontend/src/views/components/MenuRight.tsx
##########
@@ -113,9 +125,28 @@ const RightMenu = ({
}
icon={<Icons.TriangleDown />}
>
- {dropdownItems.map(
- menu =>
- findPermission(menu.perm, menu.view, roles) && (
+ {dropdownItems.map(menu => {
+ if (menu.label === 'Data') {
Review comment:
Yes I was thinking about this problem if we run into a case of a menu
having multiple submenu's. As of now the fab api is returning these menu trees.
I think it would be smart to map out where everything should going foward on
the frontend, especially if we have conditionals to where things should be
placed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
