pkdotson commented on a change in pull request #18629:
URL: https://github.com/apache/superset/pull/18629#discussion_r804301473
##########
File path: superset-frontend/src/views/components/MenuRight.tsx
##########
@@ -113,9 +125,28 @@ const RightMenu = ({
}
icon={<Icons.TriangleDown />}
>
- {dropdownItems.map(
- menu =>
- findPermission(menu.perm, menu.view, roles) && (
+ {dropdownItems.map(menu => {
+ if (menu.label === 'Data') {
Review comment:
Also it would be nice to have the backend construct the submenu tree for
cleanliness and ease but the fab api seems to only handle one level. So we
might need to this for some time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
