eschutho commented on a change in pull request #18629:
URL: https://github.com/apache/superset/pull/18629#discussion_r804266797
##########
File path: superset-frontend/src/views/components/Menu.tsx
##########
@@ -284,6 +298,7 @@ export function Menu({
className="main-nav"
>
{menu.map(item => {
+ if (item.name === 'Upload Data') return null;
Review comment:
On second thought, after reading further down, same sort of suggestion
applies here. If we don't want to render this menu because it has a submenu,
can we use the existence of a submenu as a reason not to render it rather than
the name itself, in case we want to change the name later or add more submenus?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
