kgabryje opened a new pull request #18784:
URL: https://github.com/apache/superset/pull/18784


   ### SUMMARY
   This PR implements a part of Stage 1 of native filters rework.
   Changes included:
   - Replace a pencil icon with text button - "+ Add/Edit Filters"
   - Move "apply filters" and "clear all" buttons to the bottom of filter bar 
and make them sticky. The background of the buttons container is 
semi-transparent (with a gradient) so that scrolling filters looks smoother
   - Adjust the text in empty state
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   
   
https://user-images.githubusercontent.com/15073128/154497849-c549f8d2-8138-4c60-a4c8-f128f9362f23.mov
   
   <img width="263" alt="image" 
src="https://user-images.githubusercontent.com/15073128/154497953-552ab0f6-4363-47ae-8cc3-03a8c0a2edf6.png";>
   
   ### TESTING INSTRUCTIONS
   Make sure that every button in Filters Bar works exactly like in the old 
version
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to