michael-s-molina commented on a change in pull request #18784:
URL: https://github.com/apache/superset/pull/18784#discussion_r809230848
##########
File path: superset-frontend/src/components/Button/index.tsx
##########
@@ -200,14 +200,16 @@ export default function Button(props: ButtonProps) {
},
'&[disabled], &[disabled]:hover': {
color: grayscale.base,
- backgroundColor: backgroundColorDisabled,
- borderColor: borderColorDisabled,
+ backgroundColor:
+ buttonStyle === 'link' ? 'transparent' : backgroundColorDisabled,
+ borderColor:
+ buttonStyle === 'link' ? 'transparent' : borderColorDisabled,
},
marginLeft: 0,
'& + .superset-button': {
marginLeft: theme.gridUnit * 2,
},
- '& :first-of-type': {
+ '& > :first-of-type': {
Review comment:
Can you explain why this was needed? I'm just trying to understand if
this change can impact other buttons in the application.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
