ktmud commented on code in PR #19983:
URL: https://github.com/apache/superset/pull/19983#discussion_r869556468
##########
superset-frontend/src/dashboard/actions/hydrate.js:
##########
@@ -338,7 +336,9 @@ export const hydrateDashboard =
}
const { roles } = user;
- const canEdit = canUserEditDashboard(dashboardData, user);
+ const canEdit = canUserEditDashboard(dashboard, user);
+
+ console.log(activeTabs);
Review Comment:
Thanks for catching this! I'll keep iterating on this until
https://github.com/apache/superset/pull/19966 is merged.
##########
superset-frontend/src/dashboard/actions/hydrate.js:
##########
@@ -338,7 +336,9 @@ export const hydrateDashboard =
}
const { roles } = user;
- const canEdit = canUserEditDashboard(dashboardData, user);
+ const canEdit = canUserEditDashboard(dashboard, user);
+
+ console.log(activeTabs);
Review Comment:
Thanks for catching this! I'll keep iterating on this PR until
https://github.com/apache/superset/pull/19966 is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]