[GitHub] [superset] ktmud commented on a diff in pull request #19983: feat: save active tabs in dashboard permalink

Mon, 27 Jun 2022 15:17:51 -0700 


ktmud commented on code in PR #19983:
URL: https://github.com/apache/superset/pull/19983#discussion_r907842770


##########
superset-frontend/src/dashboard/components/URLShortLinkButton/index.tsx:
##########
@@ -66,7 +77,14 @@ export default function URLShortLinkButton({
       trigger="click"
       placement={placement}
       content={
-        <div id="shorturl-popover" data-test="shorturl-popover">
+        // eslint-disable-next-line jsx-a11y/no-static-element-interactions
+        <div
+          id="shorturl-popover"
+          data-test="shorturl-popover"
+          onClick={e => {
+            e.stopPropagation();
+          }}
+        >

Review Comment:
   Stop clicking on the copy icon from switching tabs, which is kind of 
surprising/annoying----if clicking on the link icon doesn't switch tabs, then 
clicking on things in the popover triggered by the link icon shouldn't switch 
tabs either.
   
   ### Before
   
   
![tab-copy-click-before](https://user-images.githubusercontent.com/335541/176044731-170e1800-228e-452c-9954-2c9986318dba.gif)
   
   ### After
   
   
![tab-copy-click-after](https://user-images.githubusercontent.com/335541/176044995-9a477fce-fb09-4531-80fe-15ca5018e8d7.gif)
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to