ktmud commented on code in PR #19983:
URL: https://github.com/apache/superset/pull/19983#discussion_r908731993
##########
superset-frontend/src/dashboard/components/URLShortLinkButton/index.tsx:
##########
@@ -66,7 +75,14 @@ export default function URLShortLinkButton({
trigger="click"
placement={placement}
content={
- <div id="shorturl-popover" data-test="shorturl-popover">
+ // eslint-disable-next-line jsx-a11y/no-static-element-interactions
Review Comment:
The click event also triggers popover open. Since this is related to the
popover, I thought it'd make more sense to handle the event on the direct
children of the popover trigger. If we stop propagation on the icon, the
popover may not even open.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
