ktmud commented on code in PR #19983:
URL: https://github.com/apache/superset/pull/19983#discussion_r908737366
##########
superset/views/core.py:
##########
@@ -2001,13 +2001,13 @@ def dashboard_permalink( # pylint: disable=no-self-use
return redirect("/dashboard/list/")
if not value:
return json_error_response(_("permalink state not found"),
status=404)
- dashboard_id = value["dashboardId"]
+ dashboard_id, state = value["dashboardId"], value.get("state", {})
Review Comment:
Nah, just my style choice. Since they are both derived from the same
variable. It's more concise to be written in one line. This is similar to
object expansion in JS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
