codyml commented on code in PR #20369:
URL: https://github.com/apache/superset/pull/20369#discussion_r900444758
##########
superset-frontend/src/addSlice/AddSliceContainer.tsx:
##########
@@ -297,29 +313,38 @@ export default class AddSliceContainer extends
React.PureComponent<
value={this.state.datasource}
/>
<span>
- {t(
- 'Instructions to add a dataset are available in the
Superset tutorial.',
- )}{' '}
+ <a
Review Comment:
I see the argument but I'd vote to also save this for when `addSlice` is
brought into the SPA, because right now the `addSlice` React app doesn't pull
in any permissions info.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
