[GitHub] [superset] michael-s-molina commented on a diff in pull request #20369: chore(newchart): update chart creation dataset selection help text, styles

Fri, 17 Jun 2022 12:39:40 -0700 


michael-s-molina commented on code in PR #20369:
URL: https://github.com/apache/superset/pull/20369#discussion_r900457479


##########
superset-frontend/src/addSlice/AddSliceContainer.tsx:
##########
@@ -297,29 +313,38 @@ export default class AddSliceContainer extends 
React.PureComponent<
                   value={this.state.datasource}
                 />
                 <span>
-                  {t(
-                    'Instructions to add a dataset are available in the 
Superset tutorial.',
-                  )}{' '}
+                  <a

Review Comment:
   You just need to do the following change in `superset/views/chart` to 
include the permissions:
   
   <img width="584" alt="Screen Shot 2022-06-17 at 4 34 16 PM" 
src="https://user-images.githubusercontent.com/70410625/174390577-09123370-56e2-482b-ba15-b7908be14147.png";>
   
   And they will be available in Redux:
   
   <img width="341" alt="Screen Shot 2022-06-17 at 4 36 42 PM" 
src="https://user-images.githubusercontent.com/70410625/174390791-773ae4fa-cc1e-45c3-980b-65b77102e991.png";>
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to