kgabryje commented on PR #20902: URL: https://github.com/apache/superset/pull/20902#issuecomment-1200837996
> I also noticed that there are different confirmation dialog, and this one did not have save option, only cancel and leave, is this expected? are we trying to have same confirmation dialog modal when user leave explore without save? <img alt="Screen Shot 2022-08-01 at 12 33 52 AM" width="1792" src="https://user-images.githubusercontent.com/81597121/182097434-a235c2ed-268c-4724-87ff-0ab6f7a707d2.png"> Yes - our custom confirmation modal is possible to display only when navgating between SPA routes. When you try to close the tab or go to an external page, a default browser modal appears - it's not customizable in any way (it's a browser security measure) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
