kasiazjc commented on PR #20902: URL: https://github.com/apache/superset/pull/20902#issuecomment-1201270601
> > in the confirmation modal, is it make sense to have a cancel option or close dialog option? Looks like now only have discard and save, as user i may need to think about double check my change before i save, but i dont have an option currenlty. <img alt="Screen Shot 2022-08-01 at 12 29 50 AM" width="1789" src="https://user-images.githubusercontent.com/81597121/182096519-363d7101-a2ca-4ccf-9811-6d80e0a77301.png";> > > I think it makes sense! @kasiazjc wdyt? Good point, I'm thinking - maybe for consistency we should follow chrome flow actually instead of adding this one. Copy: Your chart is not saved If you leave and don't save, changes will be lost. [Cancel][Leave] Thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/81597121/182096519-363d7101-a2ca-4ccf-9811-6d80e0a77301.png"](https://user-images.githubusercontent.com/81597121/182096519-363d7101-a2ca-4ccf-9811-6d80e0a77301.png"){kind=link}