kasiazjc commented on PR #20902: URL: https://github.com/apache/superset/pull/20902#issuecomment-1205032503
> > > I think it makes sense! @kasiazjc wdyt? > > > > > > Good point, I'm thinking - maybe for consistency we should follow chrome flow actually instead of adding this one. Copy: > > Your chart is not saved If you leave and don't save, changes will be lost. [Cancel][Leave] > > Thoughts? > > Do we have a final plan for this design? My personal feeling is will be great to have all, [Cancel][Leave][Save], if that is too complicated, i think i will vote for [Cancel][Leave] which is consistent with the chrome flow, and i can always cancel and do save on explore. I try to avoid adding 3 buttons as much as possible, as it can get quite confusing. After clicking "save" we would still have to open "save" modal, so I would say let's go with [Cancel][Leave] @kgabryje -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
