rusackas commented on code in PR #22772:
URL: https://github.com/apache/superset/pull/22772#discussion_r1086896138
##########
superset-frontend/plugins/legacy-plugin-chart-sunburst/src/Sunburst.js:
##########
@@ -381,15 +382,17 @@ function Sunburst(element, props) {
.append('text')
.attr('class', 'path-abs-percent')
.attr('y', yOffsets[offsetIndex])
- .text(`${absolutePercString} of total`);
+ // eslint-disable-next-line prefer-template
+ .text(absolutePercString + ' ' + t('of total'));
if (conditionalPercString) {
offsetIndex += 1;
gMiddleText
.append('text')
.attr('class', 'path-cond-percent')
.attr('y', yOffsets[offsetIndex])
- .text(`${conditionalPercString} of parent`);
+ // eslint-disable-next-line prefer-template
+ .text(conditionalPercString + ' ' + t('of parent'));
Review Comment:
Same here to abide by the lint rules rather than disabling them, if I'm not
mistaken:
```suggestion
// eslint-disable-next-line prefer-template
.text(`${conditionalPercString} ${t('of parent')}`);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
