rusackas commented on code in PR #22772:
URL: https://github.com/apache/superset/pull/22772#discussion_r1086926015
##########
superset/connectors/base/models.py:
##########
@@ -248,10 +249,10 @@ def data(self) -> Dict[str, Any]:
for column_name in self.column_names:
column_name = str(column_name or "")
order_by_choices.append(
- (json.dumps([column_name, True]), column_name + " [asc]")
+ (json.dumps([column_name, True]), column_name + __(" [asc]"))
Review Comment:
Not sure if it makes more sense to leave the space in or out of the
translation here... perhaps out? Same issue a couple lines down.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
