rusackas commented on code in PR #22772:
URL: https://github.com/apache/superset/pull/22772#discussion_r1086920873
##########
superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm/ValidatedInputField.tsx:
##########
@@ -26,14 +26,14 @@ const FIELD_TEXT_MAP = {
helpText: t(
'Copy the account name of that database you are trying to connect to.',
),
- placeholder: 'e.g. world_population',
+ placeholder: t('e.g. world_population'),
},
warehouse: {
- placeholder: 'e.g. compute_wh',
+ placeholder: t('e.g. world_population'),
Review Comment:
This is the only string you've actually changed here... just making sure
this is intended, and the reference to "warehouse" isn't helpful to the UX.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
