rusackas commented on code in PR #22772:
URL: https://github.com/apache/superset/pull/22772#discussion_r1086923662
##########
superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx:
##########
@@ -1207,7 +1207,7 @@ const DatabaseModal:
FunctionComponent<DatabaseModalProps> = ({
required
validationMethods={{ onBlur: () => {} }}
errorMessage={validationErrors?.confirm_overwrite}
- label={t(`TYPE "OVERWRITE" TO CONFIRM`)}
+ label={t('Type "%s" to confirm', t('OVERWRITE'))}
Review Comment:
I'm thinking you're right to not have the whole sentence in uppercase here,
but pinging @jess-dillard and @kasiazjc in case there's a use case for
"yelling" that's not covered in the [Caplitalization
Guidelines](https://github.com/apache/superset/wiki/Capitalization-Guidelines).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
