eschutho commented on code in PR #22853:
URL: https://github.com/apache/superset/pull/22853#discussion_r1114901525
##########
superset-frontend/src/SqlLab/components/SaveDatasetModal/index.tsx:
##########
@@ -61,7 +61,7 @@ export type ExploreQuery = QueryResponse & {
};
export interface ISimpleColumn {
- name?: string | null;
+ column_name?: string | null;
Review Comment:
This is great to see this. IIRC there were quite a few places in the react
codebase where we had to look up either column_name or name. I found one here:
superset-frontend/packages/superset-ui-chart-controls/src/utils/getTemporalColumns.ts
Should we do a sweep through and look for more?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
