eschutho commented on code in PR #22853:
URL: https://github.com/apache/superset/pull/22853#discussion_r1114900544
##########
tests/integration_tests/sqllab_tests.py:
##########
@@ -523,8 +531,16 @@ def test_sqllab_viz_bad_payload(self):
"chartType": "dist_bar",
"schema": "superset",
"columns": [
- {"is_dttm": False, "type": "STRING", "name":
f"viz_type_{random()}"},
- {"is_dttm": False, "type": "OBJECT", "name":
f"ccount_{random()}"},
+ {
+ "is_dttm": False,
+ "type": "STRING",
+ "column_name": f"viz_type_{random()}",
Review Comment:
It's great that we're aligning the schemas here, but I would also consider
this a breaking change, so let's hold of on merging this until 3.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
