geido opened a new pull request, #23543: URL: https://github.com/apache/superset/pull/23543
### SUMMARY This PR https://github.com/apache/superset/pull/22614 introduced an issue for which the reports would not be able to execute when a filter of the FilterBar required immediate execution (see for example filters with first filter value selected by default). The reason is that the logics that run the filters are often encapsulated within the rendering of the component. By removing the rendering of the FilterBar those filters failed to execute causing the reports to fail. This PR introduces an additional way to hide the FilterBar through the `hidden` property, which effectively only hides the FilterBar with CSS while still rendering it. While not an optimal solution, this will unblock the reports. A more in-depth refactor is required to decouple the logics of the filters from the rendering of the component. ### TESTING INSTRUCTIONS 1. Visit a Dashboard with a filter having first filter value selected by default 2. Enter reports standalone mode with `standalone=3` in the url 3. Make sure the Dashboard loads while the FilterBar is hidden ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
