eschutho commented on code in PR #23543:
URL: https://github.com/apache/superset/pull/23543#discussion_r1154714065
##########
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx:
##########
@@ -51,6 +52,10 @@ import ActionButtons from './ActionButtons';
import Horizontal from './Horizontal';
import Vertical from './Vertical';
+const HiddenFilerBar = styled.div`
+ display: none;
+`;
Review Comment:
It may also keep all the styling together with the height, width, offset
properties? I assume something like `css={hidden ? hiddenStyles : undefined}`
will work, but haven't tested it. Not sure about css={hidden && hiddenStyles}`
##########
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx:
##########
@@ -51,6 +52,10 @@ import ActionButtons from './ActionButtons';
import Horizontal from './Horizontal';
import Vertical from './Vertical';
+const HiddenFilerBar = styled.div`
+ display: none;
+`;
Review Comment:
It may also keep all the styling together with the height, width, offset
properties? I assume something like `css={hidden ? hiddenStyles : undefined}`
will work, but haven't tested it. Not sure about `css={hidden && hiddenStyles}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
