kgabryje commented on code in PR #23543:
URL: https://github.com/apache/superset/pull/23543#discussion_r1154452008
##########
superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx:
##########
@@ -655,18 +658,17 @@ const DashboardBuilder: FC<DashboardBuilderProps> = () =>
{
>
<StickyPanel ref={containerRef} width={filterBarWidth}>
<ErrorBoundary>
- {!isReport && (
Review Comment:
We have a few places where we set margins for dashboard so that filter bar
fits nicely (such as lines 541 or 628). Should we set them to 0 for reports? Or
are they not visible when filter bar is hidden?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
