eschutho commented on code in PR #23543: URL: https://github.com/apache/superset/pull/23543#discussion_r1154712571
########## superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx: ########## @@ -51,6 +52,10 @@ import ActionButtons from './ActionButtons'; import Horizontal from './Horizontal'; import Vertical from './Vertical'; +const HiddenFilerBar = styled.div` + display: none; +`; Review Comment: Nit, but you can probably add this filter as a css property, and then it may be simpler than having two toggle between two Components? Example from the wiki: https://github.com/apache/superset/wiki/Emotion-Styling-Guidelines-and-Best-Practices ``` function FakeGlobalNav(props) { const menuItemStyles = css` display: block; border-bottom: 1px solid cadetblue; font-family: "Comic Sans", cursive; `; return ( <Nav> <a css={menuItemStyles} href="#">One link</a> <Link css={menuItemStyles} to={url} >Another link</Link> <div css={menuItemStyles} onclick={alert('this is not a great example`)} >Another link</Link> </Nav> ); } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
