geido commented on code in PR #23543: URL: https://github.com/apache/superset/pull/23543#discussion_r1154739876
########## superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx: ########## @@ -51,6 +52,10 @@ import ActionButtons from './ActionButtons'; import Horizontal from './Horizontal'; import Vertical from './Vertical'; +const HiddenFilerBar = styled.div` + display: none; +`; Review Comment: @eschutho the reason why I opted for this solution is that the Horizontal and Vertical components are not going to get the `css` property instructions. That's one of the limitations I find with the styled components. We would need to pass down the prop to the point where it can actually affect the target component. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
