kgabryje commented on code in PR #24686:
URL: https://github.com/apache/superset/pull/24686#discussion_r1262537364
##########
superset-frontend/src/pages/DatasetList/index.tsx:
##########
@@ -181,6 +186,11 @@ const DatasetList: FunctionComponent<DatasetListProps> = ({
setSSHTunnelPrivateKeyPasswordFields,
] = useState<string[]>([]);
+ const PREVENT_UNSAFE_DEFAULT_URLS_ON_DATASET = useSelector<
+ any,
+ DatasetListConfig
Review Comment:
Return type here should be `boolean` - `DatasetListConfig` makes typescript
think that `PREVENT_UNSAFE_DEFAULT_URLS_ON_DATASET` is an object with a field
`PREVENT_UNSAFE_DEFAULT_URLS_ON_DATASET` in it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
