dpgaspar commented on code in PR #24686:
URL: https://github.com/apache/superset/pull/24686#discussion_r1277420873


##########
UPDATING.md:
##########
@@ -41,6 +41,7 @@ assists people when migrating to a new version.
 
 ### Breaking Changes
 
+- [24686]https://github.com/apache/superset/pull/24686): All dataset's custom 
explore_url are handled as relative URLs on the frontend, behaviour controlled 
by PREVENT_UNSAFE_DEFAULT_URLS_ON_DATASET.

Review Comment:
   All `explore_url` is handled as relative, so existing URLs like: 
`http://www.google.com` will result on the following link: 
`http://localhost:8088/tablemodelview/list/http://www.google.com`
   Previously we were supporting both types, absolute URL and relative, 
internally when no value was provided we handled the default as relative 
(dataset link to explore)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to