dpgaspar commented on code in PR #24686: URL: https://github.com/apache/superset/pull/24686#discussion_r1297034122
########## UPDATING.md: ########## @@ -41,6 +41,7 @@ assists people when migrating to a new version. ### Breaking Changes +- [24686]https://github.com/apache/superset/pull/24686): All dataset's custom explore_url are handled as relative URLs on the frontend, behaviour controlled by PREVENT_UNSAFE_DEFAULT_URLS_ON_DATASET. Review Comment: Yes, I do think this breaks backward compatibility, but users can still opt in for the old behaviour, that I think it's safer and more explicit/clearer then changing metadata with a db migration. Ultimately I do question the utility of allowing users to set their own custom default URL for datasets. @michael-s-molina is it possible to include this one on 3.0.0? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
