eschutho commented on code in PR #24686: URL: https://github.com/apache/superset/pull/24686#discussion_r1264219522
########## UPDATING.md: ########## @@ -41,6 +41,7 @@ assists people when migrating to a new version. ### Breaking Changes +- [24686]https://github.com/apache/superset/pull/24686): All dataset's custom explore_url are handled as relative URLs on the frontend, behaviour controlled by PREVENT_UNSAFE_DEFAULT_URLS_ON_DATASET. Review Comment: @dpgaspar since we were already validating that all explore_urls were of the same domain, what would possibly break with this change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
