betodealmeida commented on code in PR #24942:
URL: https://github.com/apache/superset/pull/24942#discussion_r1296224860
##########
superset/db_engine_specs/pinot.py:
##########
@@ -30,93 +29,34 @@ class PinotEngineSpec(BaseEngineSpec): # pylint:
disable=abstract-method
allows_alias_in_select = False
allows_alias_in_orderby = False
- # Pinot does its own conversion below
+ #
https://docs.pinot.apache.org/users/user-guide-query/supported-transformations#datetime-functions
_time_grain_expressions = {
- TimeGrain.SECOND: "1:SECONDS",
- TimeGrain.MINUTE: "1:MINUTES",
- TimeGrain.FIVE_MINUTES: "5:MINUTES",
- TimeGrain.TEN_MINUTES: "10:MINUTES",
- TimeGrain.FIFTEEN_MINUTES: "15:MINUTES",
- TimeGrain.THIRTY_MINUTES: "30:MINUTES",
- TimeGrain.HOUR: "1:HOURS",
- TimeGrain.DAY: "1:DAYS",
- TimeGrain.WEEK: "week",
- TimeGrain.MONTH: "month",
- TimeGrain.QUARTER: "quarter",
- TimeGrain.YEAR: "year",
- }
-
- _python_to_java_time_patterns: dict[str, str] = {
- "%Y": "yyyy",
- "%m": "MM",
- "%d": "dd",
- "%H": "HH",
- "%M": "mm",
- "%S": "ss",
- }
-
- _use_date_trunc_function: dict[str, bool] = {
- TimeGrain.SECOND: False,
- TimeGrain.MINUTE: False,
- TimeGrain.FIVE_MINUTES: False,
- TimeGrain.TEN_MINUTES: False,
- TimeGrain.FIFTEEN_MINUTES: False,
- TimeGrain.THIRTY_MINUTES: False,
- TimeGrain.HOUR: False,
- TimeGrain.DAY: False,
- TimeGrain.WEEK: True,
- TimeGrain.MONTH: True,
- TimeGrain.QUARTER: True,
- TimeGrain.YEAR: True,
+ None: "{col}",
+ "PT1S": "CAST(DATE_TRUNC('second', CAST({col} AS TIMESTAMP)) AS
TIMESTAMP)",
Review Comment:
Can we keep the enums here, eg, `TimeGrain.SECOND` instead of `PT1S`? It
makes it much easier to read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
