ege-st commented on code in PR #24942:
URL: https://github.com/apache/superset/pull/24942#discussion_r1295132219
##########
superset/connectors/sqla/models.py:
##########
@@ -1011,7 +1013,7 @@ def adhoc_column_to_sqla( # pylint:
disable=too-many-locals
if is_dttm and has_timegrain:
sqla_column = self.db_engine_spec.get_timestamp_expr(
col=sqla_column,
- pdf=None,
+ pdf=pdf,
Review Comment:
@zhaoyongjie so I believe I figured out a workaround for the alias issue.
If I just set `allows_alias_in_select = False` then the query generated by
Superset does not use an alias and the query is then compatible with Pinot. So,
I don't think any of the additional changes you kindly suggested are necessary.
One question that I have is: what is the purpose of the `pdf` that gets
defined in the dataset configuration? Since it isn't passed into the engine
spec when creating a chart, it can't be used in the query generation, so it
doesn't seem to serve a purpose?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
