ege-st commented on PR #24942: URL: https://github.com/apache/superset/pull/24942#issuecomment-1679006741
Thanks, I will test the recommended changes. On Tue, Aug 15, 2023 at 9:54 AM Yongjie Zhao ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In superset/connectors/sqla/models.py > <https://github.com/apache/superset/pull/24942#discussion_r1294628722>: > > > @@ -1011,7 +1013,7 @@ def adhoc_column_to_sqla( # pylint: disable=too-many-locals > if is_dttm and has_timegrain: > sqla_column = self.db_engine_spec.get_timestamp_expr( > col=sqla_column, > - pdf=None, > + pdf=pdf, > > @ege-st <https://github.com/ege-st> the git-diffs are from Superset 2.1.0 > branch. There aren't many changes, so you should apply the changes manually > 🖨️🖨️🖨️ > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/superset/pull/24942#discussion_r1294628722>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/BAASDJYAFUBWSB6AAIG4XETXVN5SDANCNFSM6AAAAAA3KYBQUU> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
