ege-st commented on code in PR #24942:
URL: https://github.com/apache/superset/pull/24942#discussion_r1293973636
##########
superset/connectors/sqla/models.py:
##########
@@ -1011,7 +1013,7 @@ def adhoc_column_to_sqla( # pylint:
disable=too-many-locals
if is_dttm and has_timegrain:
sqla_column = self.db_engine_spec.get_timestamp_expr(
col=sqla_column,
- pdf=None,
+ pdf=pdf,
Review Comment:
@zhaoyongjie I've confirmed that this error happens with the latest versions
of Pinot: so Superset can't alias a projection to the same name as a column
that already exists. I looked at the diff you provided but it appears to be
diffing a version of `models.py` that is not the same as the one in the
`master` branch.
@john-bodley could you provide some more detail? Is SQL Alchemy generating
the alias name used in the projection? If so, then it could be an issue with
the dialect, but if Superset generates the alias label then I'm not sure how
the dialect can address this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
