mistercrunch commented on PR #26602: URL: https://github.com/apache/superset/pull/26602#issuecomment-1928545991
Is there an opportunity as part of this PR to improve accessibility by reusing (or introducing if they don't exist already) low-level reusable components in `src/components` and make those accessible? The original idea with `src/components` was [amongst other things] to offer a subset of `antd` (and native React like `<a>` or `button`) components that are more opinionated on properties (offer only a subset of properties) and used/reused consistently across Superset. Say if we always use `src.components.Button` and that one always has a `role`, then no need to sprinkle `role` in a hundred places (?) Similar with `antd.MenuItem`, if we have a nice little abstraction where you can't get it wrong, then no need to go low level across the codebase, simply in `src/components/` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
