mistercrunch commented on code in PR #26602:
URL: https://github.com/apache/superset/pull/26602#discussion_r1479082544
##########
superset-frontend/src/components/CachedLabel/index.tsx:
##########
@@ -44,6 +44,7 @@ const CacheLabel: React.FC<CacheLabelProps> = ({
<Label
className={`${className}`}
type={labelType}
+ role="button"
Review Comment:
Following up on my higher level comment about fixing in low-level
components, it looks like in this particular context, `Label` is pointing to
`superset-frontend/src/components/Label/index.tsx`.
Could we simply for `role="button"` when `onClick` is defined? This would
tackle all labels at once and prevent having to sprinkle the role prop across
the code base, and forgetting to specify it in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
