mistercrunch commented on PR #26602: URL: https://github.com/apache/superset/pull/26602#issuecomment-1928561690
Similarly, looking at all the many `<Menu />` and `<MenuItem />` entries here, you could really just force role="button" if/when `onClick` is defined, and not have to sprinkle `role="button"` everywhere. We should have a hard rule to ALWAYS use antd component through the wrappers in `src/components/` meaning we always do this lower level stuff from that central point. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
