justinpark commented on code in PR #29163:
URL: https://github.com/apache/superset/pull/29163#discussion_r1913921283
##########
superset-frontend/src/SqlLab/components/ShareSqlLabQuery/index.tsx:
##########
@@ -92,7 +96,7 @@ const ShareSqlLabQuery = ({
};
const getCopyUrl = (callback: Function) => {
if (isFeatureEnabled(FeatureFlag.ShareQueriesViaKvStore)) {
- return getCopyUrlForKvStore(callback);
+ return getCopyUrlForPermalink(callback);
Review Comment:
> I feel we could now remove the feature flag, and make this the default
behavior.
@villebro Done. permalink sets to default now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
