michael-s-molina commented on code in PR #29163:
URL: https://github.com/apache/superset/pull/29163#discussion_r1916808741
##########
superset-frontend/src/types/bootstrapTypes.ts:
##########
@@ -164,6 +164,7 @@ export interface BootstrapData {
dashboard_id: string;
};
requested_query?: JsonObject;
+ permalink?: string;
Review Comment:
This looks weird 🤔 Why do you need something that's in the URL?
##########
RESOURCES/FEATURE_FLAGS.md:
##########
@@ -62,6 +62,7 @@ These features flags are **safe for production**. They have
been tested and will
[//]: # "PLEASE KEEP THESE LISTS SORTED ALPHABETICALLY"
### Flags on the path to feature launch and flag deprecation/removal
+
Review Comment:
Did you forget to remove the `SHARE_QUERIES_VIA_KV_STORE` and `KV_STORE`
from this document?
##########
UPDATING.md:
##########
@@ -32,7 +33,8 @@ assists people when migrating to a new version.
- [31262](https://github.com/apache/superset/pull/31262) NOTE: deprecated
`pylint` in favor of `ruff` as our only python linter. Only affect development
workflows positively (not the release itself). It should cover most important
rules, be much faster, but some things linting rules that were enforced before
may not be enforce in the exact same way as before.
- [31173](https://github.com/apache/superset/pull/31173) Modified
`fetch_csrf_token` to align with HTTP standards, particularly regarding how
cookies are handled. If you encounter any issues related to CSRF functionality,
please report them as a new issue and reference this PR for context.
- [31385](https://github.com/apache/superset/pull/31385) Significant docker
refactor, reducing access levels for the `superset` user, streamlining layer
building, ...
-- [31503](https://github.com/apache/superset/pull/31503) Deprecating python
3.9.x support, 3.11 is now the recommended version and 3.10 is still supported
over the Superset 5.0 lifecycle.
+- [31503](https://github.com/apache/superset/pull/31503) Deprecating python
3.9.x support, 3.11 is now the recommended version and 3.10 is still supported
over the Superset 5.0 lifecycle.
+- [29163](https://github.com/apache/superset/pull/29163) The /kv/ API used in
the SQL Lab share link has been deprecated and replaced with a permalink. The
legacy share link (i.e., /sqllab/?id=xxxx) will be temporarily available in 5.0
but will no longer be supported in 6.0
Review Comment:
```suggestion
- [29163](https://github.com/apache/superset/pull/29163) Removed the
`SHARE_QUERIES_VIA_KV_STORE` and `KV_STORE` feature flags and changed the way
Superset shares SQL Lab queries to use permalinks. The legacy `/kv` API was
removed but we still support legacy links in 5.0. In 6.0, only permalinks will
be supported.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
