michael-s-molina commented on code in PR #29163: URL: https://github.com/apache/superset/pull/29163#discussion_r1914662232
########## UPDATING.md: ########## @@ -31,6 +31,7 @@ assists people when migrating to a new version. - [31262](https://github.com/apache/superset/pull/31262) NOTE: deprecated `pylint` in favor of `ruff` as our only python linter. Only affect development workflows positively (not the release itself). It should cover most important rules, be much faster, but some things linting rules that were enforced before may not be enforce in the exact same way as before. - [31173](https://github.com/apache/superset/pull/31173) Modified `fetch_csrf_token` to align with HTTP standards, particularly regarding how cookies are handled. If you encounter any issues related to CSRF functionality, please report them as a new issue and reference this PR for context. - [31385](https://github.com/apache/superset/pull/31385) Significant docker refactor, reducing access levels for the `superset` user, streamlining layer building, ... +- [29163](https://github.com/apache/superset/pull/29163) Deprecated the `SHARE_QUERIES_VIA_KV_STORE` feature flag Review Comment: I think this needs to be updated to reflect the last state. It should also say that we will stop supporting the old links in 6.0. ########## RESOURCES/FEATURE_FLAGS.md: ########## @@ -101,3 +101,4 @@ These features flags currently default to True and **will be removed in a future - DRILL_TO_DETAIL - ENABLE_JAVASCRIPT_CONTROLS - KV_STORE +- SHARE_QUERIES_VIA_KV_STORE Review Comment: ```suggestion ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
