justinpark commented on code in PR #29163:
URL: https://github.com/apache/superset/pull/29163#discussion_r1917206431


##########
superset-frontend/src/types/bootstrapTypes.ts:
##########
@@ -164,6 +164,7 @@ export interface BootstrapData {
     dashboard_id: string;
   };
   requested_query?: JsonObject;
+  permalink?: string;

Review Comment:
   Replace the bootstrap logic by parsing the url path



##########
superset-frontend/src/types/bootstrapTypes.ts:
##########
@@ -164,6 +164,7 @@ export interface BootstrapData {
     dashboard_id: string;
   };
   requested_query?: JsonObject;
+  permalink?: string;

Review Comment:
   Replaced the bootstrap logic by parsing the url path



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to