korbit-ai[bot] commented on code in PR #32336:
URL: https://github.com/apache/superset/pull/32336#discussion_r1980144308
##########
superset/reports/api.py:
##########
@@ -574,7 +575,7 @@ def slack_channels(self, **kwargs: Any) -> Response:
"""
try:
params = kwargs.get("rison", {})
- search_string = params.get("search_string")
+ search_string = get_recipients_list(params.get("search_string"))
Review Comment:
Thanks for the clarification, @Vitor-Avila. It seems reasonable to use
another method for handling the string processing. However, it would still be
better to handle this functionality without involving the `get_recipients_list`
function, as the search string should not be a list of recipients.
Reformulating the code to handle the search string without inadvertent
splitting or altering would be beneficial for avoiding future errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
