eschutho commented on code in PR #32336:
URL: https://github.com/apache/superset/pull/32336#discussion_r1982281457
##########
superset/commands/report/execute.py:
##########
@@ -571,10 +586,13 @@ def _send(
recipient.type = ReportRecipientType.SLACKV2
notification = create_notification(recipient,
notification_content)
notification.send()
- except (UpdateFailedError, NotificationParamException) as err:
- # log the error but keep processing the report with SlackV1
- logger.warning(
- "Failed to update slack recipients to v2: %s", str(err)
+ except (UpdateFailedError, NotificationParamException) as
mig_err:
Review Comment:
can you catch these errors below on line 597?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
