eschutho commented on code in PR #32336:
URL: https://github.com/apache/superset/pull/32336#discussion_r1982287169


##########
superset/utils/core.py:
##########
@@ -811,7 +811,13 @@ def send_mime_email(
     smtp.quit()
 
 
-def get_email_address_list(address_string: str) -> list[str]:
+def get_recipients_list(address_string: str | None) -> list[str]:

Review Comment:
   Since this isn't really fetching anything, can we change it to sound more 
like a utility, like "recipient_string_to_list"?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to