eschutho commented on code in PR #32336:
URL: https://github.com/apache/superset/pull/32336#discussion_r1982267371
##########
superset/reports/api.py:
##########
@@ -574,7 +574,7 @@ def slack_channels(self, **kwargs: Any) -> Response:
"""
try:
params = kwargs.get("rison", {})
- search_string = params.get("search_string")
+ search_string = [params.get("search_string", "").strip()]
Review Comment:
Any benefit for doing the search string cleanup here (and other place where
you pass it to `get_channels_with_search`) as opposed to letting the
`get_channels_with_search` be responsible for it in one place?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
